Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ready: Cors #451

Draft
wants to merge 32 commits into
base: main
Choose a base branch
from
Draft

Ready: Cors #451

wants to merge 32 commits into from

Conversation

ethanstrominger
Copy link
Member

@ethanstrominger ethanstrominger commented Nov 30, 2024 •
edited
Loading

Fixes #replace_this_text_with_the_issue_number

What changes did you make?

  • update-table.md : minor change from .pre-commit

Following files were changed to implement /login API so that developers can test the API without connecting to COGNITO

  • custom_api.py
  • urls.py
  • views.py: add patch method to user
  • settings.py: change Move JWT setting to be conditional based on COGNITO variables being set. See also CORS changes

CORS changes

  • settings.py
  • .env.docker-example
  • requirements.txt

Build related changes:

  • buildrun.sh: remove -d flag to make it easier to find out why Django API Server returns an error
  • remove echo DJANGO_SUPERUSER as sometimes this would make script fail
  • docker-compose.yml: avoid running mkdocs by setting env variable

Why did you make the changes?

  • make changes so you can call from REACT
  • Add a login URL for developer so you do not need to connect to COGNITO

ethanstrominger and others added 30 commits October 16, 2024 08:10
@ethanstrominger
Enable CORS for React application
582dfde
@ethanstrominger
Partially working, some code commented out
dd3fc1c
@ethanstrominger
Handle jwt decode error,
4627e3f
@ethanstrominger
WIP
2553707
@ethanstrominger
Small changes
0c52805
@ethanstrominger
Resolve views.py conflict
e94bfd6
@ethanstrominger
Merge branch 'main' of https://github.com/hackforla/peopledepot into …
83082c8 
…cors
@ethanstrominger
Change post to patch
884e8d4
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
319ae56 
for more information, see https://pre-commit.ci
@ethanstrominger
Changes to support React
72f72dc
@ethanstrominger
Changes for CORS so REACT works
e1de3dc
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
3e96aaf 
for more information, see https://pre-commit.ci
@ethanstrominger
Add blank line
1c31653
@ethanstrominger
Merge branch 'cors' of https://github.com/ethanstrominger/peopledepot …
dd4036b 
…into cors
@ethanstrominger
Revert changes to files related to /login local
6b233c9
@ethanstrominger
Merge branch 'cors' of https://github.com/ethanstrominger/peopledepot …
698a3eb 
…into cors
@ethanstrominger
Remove /login API implementation
dc5b878
@ethanstrominger
Restore jwt.py
dddcb7c
@ethanstrominger
Restore update-table.md
ace3579
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
368e92a 
for more information, see https://pre-commit.ci
@ethanstrominger
Restore jwt.py
6d69f40
@ethanstrominger
Merge branch 'cors' of https://github.com/ethanstrominger/peopledepot …
f6e880f 
…into cors
@ethanstrominger
Remove duplicate env variable in .env.docker-example
ac7bb08
@ethanstrominger
Restore docker-compose.yml
9cc11eb
@ethanstrominger
Remove unused import
ddfe984
@ethanstrominger
pre-commit and update-table.md
ed177de
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
1909194 
for more information, see https://pre-commit.ci
@ethanstrominger
Try to fix update-table.md hanging space
8e1f7db
@ethanstrominger
Merge branch 'cors' of https://github.com/ethanstrominger/peopledepot …
c18fe5d 
…into cors
@ethanstrominger
Squashed commit of the following:
8d9bd82 
commit 0d70d8f
Author: Ethan Strominger <[email protected]>
Date:   Wed Dec 18 11:42:21 2024 -0500

    Update graphviz

commit 775d753
Author: Ethan Strominger <[email protected]>
Date:   Sun Dec 1 17:25:56 2024 -0500

    Modify to tricker pre-commit

commit c75db16
Author: Ethan Strominger <[email protected]>
Date:   Sun Dec 1 17:23:16 2024 -0500

    Fix trailing whitespace
@ethanstrominger
Merge branch 'cors' of https://github.com/ethanstrominger/peopledepot …
8a73893 
…into cors
@ethanstrominger
Squashed commit of the following:
2924fb9 
commit 0d70d8f
Author: Ethan Strominger <[email protected]>
Date:   Wed Dec 18 11:42:21 2024 -0500

    Update graphviz

commit 775d753
Author: Ethan Strominger <[email protected]>
Date:   Sun Dec 1 17:25:56 2024 -0500

    Modify to tricker pre-commit

commit c75db16
Author: Ethan Strominger <[email protected]>
Date:   Sun Dec 1 17:23:16 2024 -0500

    Fix trailing whitespace
@ethanstrominger ethanstrominger changed the title Cors Ready: Cors Dec 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
P: PD: Project Board
Status: PR Needs review (automated column, do not place items here manually)
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ethanstrominger